docs: pipeline: inputs: gpu-metrics: document NVIDIA NVML support and enable_nvml - #2630
Conversation
|
Warning Review limit reached
Next review available in: 37 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe GPU metrics guide now documents AMD and NVIDIA support, NVIDIA-specific metrics, NVML configuration and fallback behavior, detection of supported cards, filtering options, and NVML-enabled YAML and Fluent Bit configuration examples. ChangesGPU metrics documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cosmo0920
left a comment
cosmo0920
left a comment
There was a problem hiding this comment.
For technical view points, it looks good to me! 👍
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pipeline/inputs/gpu-metrics.md`:
- Around line 94-96: Clarify the GPU filter documentation so NVIDIA values for
cards_include, cards_exclude, and the card label are selected using NVML
enumeration from nvidia-smi -L, distinct from AMD/sysfs /sys/class/drm/card*
names. Add the explicit command before explaining how to choose NVIDIA filter
values, without changing the existing parameter behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9b013f7f-7988-4b85-92a4-7f6a6f0d4b43
📒 Files selected for processing (1)
pipeline/inputs/gpu-metrics.md
… enable_nvml - Correct intro: NVIDIA GPUs are now supported via NVML (libnvidia-ml) - Add enable_nvml configuration option (default true) - Add gpu_process_memory_used_bytes and gpu_mig_device_info metrics - Note card/vendor labels (vendor: amd or nvidia) - Split GPU detection into AMD and NVIDIA subsections - Add enable_nvml to YAML and classic config examples - Clarify per-vendor card filtering: AMD sysfs number vs NVIDIA NVML index (nvidia-smi -L); note NVIDIA card label is the GPU UUID Note this action needed due to code changes without docs PR. Signed-off-by: Eric D. Schabell <eric@schabell.org>
6daf88b to
964ecdc
Compare
|
@patrick-stephens ready for review! |
3 participants
Note this action needed due to code changes without docs PR.
Summary by CodeRabbit
cardandvendorlabels.